Skip to content

Conversation

@Dreagonmon
Copy link
Contributor

Questions

Describe your pull request

fix build script for Non-English environment.

I want to test my modified version of playbook, but the output of the test target seems having a broken xml format.

It turns out that I use the Chinese environment and powershell use the Chinese encoding to read and write playbook.conf file, that would break the Description content which contains special characters.

So here is the fix, simply add -Encoding to the read and write commands.

@Dreagonmon Dreagonmon requested a review from Xyueta as a code owner December 6, 2024 17:04
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Dec 6, 2024
@Dreagonmon Dreagonmon changed the title fix build script for Non-English environment fix: build script for Non-English environment Dec 6, 2024
@TheyCreeper
Copy link
Member

TheyCreeper commented Feb 17, 2025

Does this impact installing AtlasOS on your system ? (not a custom build, normal playbook)
Edit: I didn't check that it was only modifying local-build.ps1. It's fine

Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dreagonmon
Copy link
Contributor Author

Does this impact installing AtlasOS on your system ? (not a custom build, normal playbook) Edit: I didn't check that it was only modifying local-build.ps1. It's fine

No, the normal release from the offical website works fine for me. (Though in China the network is a big pain, thats why I want to modify it to support applying most of the scripts totally offline.)

It just prevents me from building the playbook correctly. The build is success, but the final output is not good, and the custom playbook can't be applied.

After adding these parameters, it works for me.

@TheyCreeper
Copy link
Member

Does this impact installing AtlasOS on your system ? (not a custom build, normal playbook) Edit: I didn't check that it was only modifying local-build.ps1. It's fine

No, the normal release from the offical website works fine for me. (Though in China the network is a big pain, thats why I want to modify it to support applying most of the scripts totally offline.)

It just prevents me from building the playbook correctly. The build is success, but the final output is not good, and the custom playbook can't be applied.

After adding these parameters, it works for me.

yeah that's what I thought too, we'll merge when the codeowners validate it.

@RadNotRed RadNotRed merged commit a904609 into Atlas-OS:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playbook Playbook related issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants