Skip to content

Fix Hybrid A* #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2020
Merged

Fix Hybrid A* #327

merged 3 commits into from
May 7, 2020

Conversation

guilyx
Copy link
Contributor

@guilyx guilyx commented May 5, 2020

Fix issue #325

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented May 6, 2020

Thank you!! Is it possible to add a test? It is ok just adding a new test code "test_hybrid_a_star.py" in the tests dir.
a_star test code might help: https://github.com/AtsushiSakai/PythonRobotics/blob/master/tests/test_a_star.py

Copy link

@lentychang lentychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guilyx ,

Since N_STEER is declared line27 and is only used in this function, would it be better to change line 27 from N_STEER=20.0 to N_STEER = 20 instead?

@guilyx
Copy link
Contributor Author

guilyx commented May 6, 2020

@lentychang indeed !

@guilyx
Copy link
Contributor Author

guilyx commented May 6, 2020

Added the tests and changed N_STEER according to @lentychang's suggestion.
@AtsushiSakai as E722 do not use bare 'except and all the tests uses bare excepts there might be something to do.

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented May 7, 2020

@guilyx @lentychang Thank you guys!!. I will merge it.

all the tests uses bare excepts there might be something to do.

Oh. Yes. these codes should do it. That's why I'm using incremental code check : ).

@AtsushiSakai AtsushiSakai merged commit 2b00207 into AtsushiSakai:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants