Skip to content

Add CodeQL security scanning #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

jhutchings1
Copy link
Contributor

Hi, I'm a PM on the GitHub security team. This repository is eligible to try the new GitHub Advanced Security code scanning beta.

Code scanning runs a static analysis tool called CodeQL which scans your code at build time to find any potential security issues. We've tuned the set of queries to be only the most severe, most precise issues. We'll show alerts in the security tab, and we'll show alerts for any net new vulnerabilities on pull requests as well. We've tried to make this super developer friendly, but we'd love your feedback as we work through the beta.

If you're interested in trying it out, you can merge this pull request to set up the Actions workflow.

@jhutchings1 jhutchings1 marked this pull request as ready for review June 3, 2020 17:18
@jhutchings1
Copy link
Contributor Author

Hi @AtsushiSakai! The code scanning build is working. This will cover the same scenarios that LGTM does, although it uses a slightly smaller query set. If you'd like to use this instead of LGTM and use the same set of queries, let me know and I can help you get the right configuration in place.

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jun 4, 2020

@jhutchings1 Hi. Thank you for your PR. The new features looks great!!.

If you'd like to use this instead of LGTM and use the same set of queries,

Yes, I'm interested in it, but I want to use both LGTM and the new one for comparing.

@jhutchings1
Copy link
Contributor Author

You bet! I just pushed a change that extends code scanning to use the same set of queries as LGTM.

@AtsushiSakai
Copy link
Owner

@jhutchings1 Thank you!!. Is it possible to fix Code Factor warning? It reports there is a tailing white space.

@jhutchings1
Copy link
Contributor Author

@jhutchings1 Thank you!!. Is it possible to fix Code Factor warning? It reports there is a tailing white space.

You bet. I just pushed a change that should fix that warning.

@AtsushiSakai AtsushiSakai merged commit d1bde58 into AtsushiSakai:master Jun 5, 2020
@AtsushiSakai
Copy link
Owner

Thank you so much!! I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants