Update setValidSubscriptionAmount, setValidAmount and setValidTransac…

…tionAmount to return amounts as #.## instead of whole numbers

and in range between 1.00 and either maxTransactionAmount or maxSubscriptionAmount

AuthorizeNETtest/Api/Controllers/SampleTest/CreateCustomerProfileFromTransactionSampleTest.cs

@@ -83,7 +83,7 @@ private long GetTransactionId()
             ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
 
             //set up data based on transaction
-            var transactionAmount = SetValidTransactionAmount(Counter)/100;
+            var transactionAmount = SetValidTransactionAmount(Counter);
             var creditCard = new creditCardType { cardNumber = "4111111111111111", expirationDate = "0622" };
             var aCustomer = new customerDataType { email = string.Format( "{0}@b.bla", Counter)};
 

AuthorizeNETtest/Api/Controllers/SampleTest/CreateTransactionSampleTest.cs

@@ -115,7 +115,7 @@ public void SampleCodeCreateTransactionUsingProfile()
             var transactionRequestType = new transactionRequestType
             {
                 transactionType = transactionTypeEnum.authCaptureTransaction.ToString(),
-                amount = SetValidTransactionAmount(Counter)/100,
+                amount = SetValidTransactionAmount(Counter),
                 profile = profileToCharge
             };
             var createRequest = new createTransactionRequest
@@ -266,7 +266,7 @@ public void SampleCodeCreateTransactionWithPayPal()
         {
             //Common code to set for all requests
             ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
-            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = AuthorizeNet.Environment.SANDBOX; //TestEnvironment;
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = AuthorizeNet.Environment.PLUM; //TestEnvironment;
 
             //set up data for transaction
             var transactionAmount = SetValidTransactionAmount(Counter) / 100;
@@ -443,5 +443,49 @@ public void SampleCodeCreateTransactionPriorAuthCapture()
             //validate
             Assert.AreEqual("1", capResponse.transactionResponse.messages[0].code);
         }
+
+        [Test]
+        public void TransactionRequest_HandleError()
+        {
+            LogHelper.info(Logger, "CreateProfileWithCreateTransactionRequestTest");
+
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
+
+            //create a transaction
+            var transactionRequestType = new transactionRequestType
+            {
+                transactionType = transactionTypeEnum.authCaptureTransaction.ToString(),
+                amount = SetValidTransactionAmount(Counter),
+                payment = new paymentType { Item = new creditCardType { cardNumber = "0111111111111111", expirationDate = "122035" } },
+                order = OrderType,
+                customer = CustomerDataOne,
+                billTo = CustomerAddressOne,
+                shipTo = CustomerAddressOne,
+            };
+            var createRequest = new createTransactionRequest
+            {
+                refId = RefId,
+                transactionRequest = transactionRequestType,
+            };
+            //create controller, execute and get response
+            var createController = new createTransactionController(createRequest);
+            createController.Execute();
+            var createResponse = createController.GetApiResponse();
+
+            //Validate error code where request is submitted properly, but request fails.
+            Assert.AreEqual("6", createResponse.transactionResponse.errors[0].errorCode);
+
+            //Validate error code where submission of request fails.
+            ((creditCardType)transactionRequestType.payment.Item).cardNumber = "01";
+            createController = new createTransactionController(createRequest);
+            createController.Execute();
+
+            if (createController.GetApiResponse() == null)
+            {
+                var errorResponse = createController.GetErrorResponse();
+                Assert.AreEqual("E00003", errorResponse.messages.message[0].code);
+            }
+        }
     }
 }

AuthorizeNETtest/Api/Controllers/Test/ApiCoreTestBase.cs

@@ -300,7 +300,6 @@ public void SetUp()
                     interval = interval,
                     startDate = _nowDate,
                     totalOccurrences = 5,
-                    trialOccurrences = 0, 
                 };
 
             ArbSubscriptionOne = new ARBSubscriptionType
@@ -313,7 +312,6 @@ public void SetUp()
                     payment = PaymentOne,
                     paymentSchedule = PaymentScheduleTypeOne,
                     shipTo = NameAndAddressTypeOne,
-                    trialAmount= SetValidSubscriptionAmount(0),
                 };
 
             CustomerDataOne = new customerDataType
@@ -360,8 +358,15 @@ public decimal SetValidSubscriptionAmount(int number)
 		    return setValidAmount(number, MaxSubscriptionAmount);
 	    }
 
-	    private decimal setValidAmount(int number, int maxAmount) {
-            return new decimal(number > maxAmount ? (number % maxAmount) : number);
+	    private decimal setValidAmount(int number, int maxAmount)
+        {
+            //Test that result is not larger than the specified max value
+            number = (number > maxAmount) ? (number % maxAmount) : number;
+
+            Decimal dollarsAndCents = (decimal)number / 100;
+
+            //Test that result is not less than the global Min Value
+            return dollarsAndCents = (dollarsAndCents < MinAmount) ? (MinAmount + dollarsAndCents) : dollarsAndCents;
 	    }
 
 	    static ANetApiResponse _errorResponse;
@@ -372,6 +377,7 @@ protected ANetApiResponse GetErrorResponse() {
 
         private const int MaxSubscriptionAmount = 1000; //214747;
         private const int MaxTransactionAmount = 10000; //214747;
+        private const int MinAmount = 1;
         private const decimal TaxRate = 0.10m;
 
         protected static TS ExecuteTestRequestWithSuccess<TQ, TS, TT>(TQ request, AuthorizeNet.Environment execEnvironment = null)

AuthorizeNETtest/Api/Controllers/Test/ArbSubscriptionTest.cs

@@ -3,6 +3,8 @@ namespace AuthorizeNet.Api.Controllers.Test
     using System;
     using AuthorizeNet.Api.Contracts.V1;
     using AuthorizeNet.Api.Controllers;
+    using AuthorizeNet.Api.Controllers.Bases;
+    using AuthorizeNet.Api.Controllers.Test;
     using AuthorizeNet.Util;
     using NUnit.Framework;
     using System.Linq;
@@ -94,30 +96,112 @@ public void TestGetSubscriptionList()
 
 	    [Test]
 	    public void TestSubscription() {
-            //create a transaction
-            var transactionRequestType = new transactionRequestType
+            Random rnd = new Random(DateTime.Now.Millisecond);
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
+
+            //create a subscription
+            var subscriptionDef = new ARBSubscriptionType
             {
-                transactionType = transactionTypeEnum.authCaptureTransaction.ToString(),
-                amount = SetValidTransactionAmount(Counter),
+                paymentSchedule = new paymentScheduleType
+                {
+                    interval = new paymentScheduleTypeInterval
+                    {
+                        length = 1,
+                        unit = ARBSubscriptionUnitEnum.months,
+                    },
+                    startDate = DateTime.UtcNow,
+                    totalOccurrences = 12,
+                },
+
+
+                amount = 9.99M,
+                billTo = CustomerAddressTwo,
+
                 payment = PaymentOne,
-                order = OrderType,
-                customer = CustomerDataOne,
-                billTo = CustomerAddressOne,
+
+                customer = CustomerOne,
+
+                order = new orderType { description = string.Format("member monthly {0}", rnd.Next(99999)) },
             };
-            var createRequest = new createTransactionRequest
+
+            var arbRequest = new ARBCreateSubscriptionRequest { subscription = subscriptionDef };
+            var arbController = new ARBCreateSubscriptionController(arbRequest);
+            arbController.Execute();
+
+            var arbCreateResponse = arbController.GetApiResponse();
+
+            Assert.AreEqual(messageTypeEnum.Ok,arbController.GetResultCode());
+
+	    }
+
+        [Test]
+        public void TestSubscription_ExpiredCC()
+        {
+            Random rnd = new Random(DateTime.Now.Millisecond);
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
+            //create a subscription
+            var subscriptionDef = new ARBSubscriptionType
             {
-                refId = RefId,
-                transactionRequest = transactionRequestType,
-                merchantAuthentication = CustomMerchantAuthenticationType,
+
+
+                paymentSchedule = new paymentScheduleType
+                {
+                    interval = new paymentScheduleTypeInterval
+                    {
+                        length = 7,
+                        unit = ARBSubscriptionUnitEnum.days
+                    },
+                    startDate = DateTime.UtcNow,
+                    totalOccurrences = 2,
+                },
+
+
+                amount = 9.99M,
+
+                billTo = new nameAndAddressType
+                {
+                    address = "1234 Elm St NE",
+                    city = "Bellevue",
+                    state = "WA",
+                    zip = "98007",
+                    firstName = "First",
+                    lastName = "Last"
+                },
+
+                payment = new paymentType
+                {
+                    Item = new creditCardType
+                                 {
+                                     cardCode = "655",
+                                     //cardNumber = "4007000",
+                                     cardNumber = "4111111111111111",
+                                     expirationDate = "122013",
+                                 }
+                },
+
+                customer = new customerType { email = "[email protected]", id = "5", },
+
+                order = new orderType { description = string.Format("member monthly {0}", rnd.Next(99999)) },
             };
 
-            var createResponse = ExecuteTestRequestWithSuccess<createTransactionRequest, createTransactionResponse, createTransactionController>(createRequest, TestEnvironment);
-            string txnId = createResponse.transactionResponse.transId;
+            var arbRequest = new ARBCreateSubscriptionRequest { subscription = subscriptionDef };
+            var arbController = new ARBCreateSubscriptionController(arbRequest);
+            arbController.Execute();
 
-		    var subscriptionId = CreateSubscription(CustomMerchantAuthenticationType, txnId);
-		    GetSubscription(CustomMerchantAuthenticationType, subscriptionId);
-		    CancelSubscription(CustomMerchantAuthenticationType, subscriptionId);
-	    }
+            var arbCreateResponse = arbController.GetApiResponse();
+
+            //If request responds with an error, walk the messages and get code and text for each message.
+            if (arbController.GetResultCode() == messageTypeEnum.Error)
+            {
+                foreach(var msg in arbCreateResponse.messages.message)
+                {
+                    Console.WriteLine("Error Num = {0}, Message = {1}", msg.code, msg.text);
+                }
+            }
+
+        }
 
 	    private ARBGetSubscriptionListRequest SetupSubscriptionListRequest(merchantAuthenticationType merchantAuthentication) {
 
@@ -171,7 +255,8 @@ private ARBSubscriptionStatusEnum GetSubscription(merchantAuthenticationType mer
 		    return getResponse.status;
 	    }
 
-	    private string CreateSubscription( merchantAuthenticationType merchantAuthentication, string RefId) {
+        private string CreateSubscription( merchantAuthenticationType merchantAuthentication, string RefId) 
+        {
 		    //create a new subscription
             //RequestFactoryWithSpecified.paymentType(ArbSubscriptionOne.payment);
             //RequestFactoryWithSpecified.paymentScheduleType(ArbSubscriptionOne.paymentSchedule);
@@ -190,5 +275,49 @@ private string CreateSubscription( merchantAuthenticationType merchantAuthentica
 
 		    return createResponse.subscriptionId;
 	    }
+
+        [Test]
+        public void TestSubscription_serialization_error()
+        {
+            Random rnd = new Random(DateTime.Now.Millisecond);
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
+            ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
+
+            //create a subscription
+            var subscriptionDef = new ARBSubscriptionType
+            {
+                paymentSchedule = new paymentScheduleType
+                {
+                    interval = new paymentScheduleTypeInterval
+                    {
+                        length = 1,
+                        unit = ARBSubscriptionUnitEnum.months,
+                    },
+                    startDate = DateTime.UtcNow,
+                    totalOccurrences = 12,
+                },
+
+
+                amount = 9.99M,
+                billTo = new customerAddressType { firstName = "first", lastName = "last" },
+
+                payment = PaymentOne,
+
+                customer = CustomerOne,
+
+                order = new orderType { description = string.Format("member monthly {0}", rnd.Next(99999)) },
+            };
+
+            var arbRequest = new ARBCreateSubscriptionRequest { subscription = subscriptionDef };
+            var arbController = new ARBCreateSubscriptionController(arbRequest);
+            arbController.Execute();
+
+            if (arbController.GetResultCode() == messageTypeEnum.Error)
+            {
+                var errorResp = arbController.GetErrorResponse();
+                Console.WriteLine("{0}: {1}", errorResp.messages.message[0].code, errorResp.messages.message[0].text);
+            }
+
+        }
     }
 }

AuthorizeNETtest/CardPresentGatewayTest.cs

@@ -90,7 +90,7 @@ public void SendTest_PriorAuthCap_Approved()
             Assert.IsTrue(sError == "", sError);
 
             //setup
-            decimal amount = (decimal) 30.13;
+            decimal amount = getValidAmount();
             string transID = SendAuthOnly(amount + 1, true);
             Assert.IsTrue(transID.Trim().Length > 0);
             Assert.IsTrue(long.Parse(transID) > 0);
@@ -128,7 +128,7 @@ public void SendTest_PriorAuthCap_LessAmount_Failed()
             Assert.IsTrue(sError == "", sError);
 
             //setup
-            decimal amount = (decimal)30.13;
+            decimal amount = getValidAmount();
             string transID = SendAuthOnly(amount - 1, true);
             Assert.IsTrue(transID.Trim().Length > 0);
             Assert.IsTrue(long.Parse(transID) > 0);

AuthorizeNETtest/CustomerGatewayTest.cs

@@ -653,7 +653,9 @@ public void AuthorizeAndCaptureTest()
             string sError = CheckLoginPassword();
             Assert.IsTrue(sError == "", sError);
 
-            string responseString = "<?xml version=\"1.0\" encoding=\"utf-8\"?><createCustomerProfileTransactionResponse xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\" xmlns=\"AnetApi/xml/v1/schema/AnetApiSchema.xsd\"><messages><resultCode>Ok</resultCode><message><code>I00001</code><text>Successful.</text></message></messages><directResponse>1,1,1,This transaction has been approved.,2C99N3,Y,2207640586,,,25.10,CC,auth_capture,,,,,,,,,,,,[email protected],,,,,,,,,,,,,,C40BBCC10984A7A95471323B34FD4FFB,,2,,,,,,,,,,,XXXX1111,Visa,,,,,,,,,,,,,,,,</directResponse></createCustomerProfileTransactionResponse>";
+            decimal txnAmount = getValidAmount();
+
+            string responseString = string.Format("<?xml version=\"1.0\" encoding=\"utf-8\"?><createCustomerProfileTransactionResponse xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\" xmlns=\"AnetApi/xml/v1/schema/AnetApiSchema.xsd\"><messages><resultCode>Ok</resultCode><message><code>I00001</code><text>Successful.</text></message></messages><directResponse>1,1,1,This transaction has been approved.,2C99N3,Y,2207640586,,,{0},CC,auth_capture,,,,,,,,,,,,[email protected],,,,,,,,,,,,,,C40BBCC10984A7A95471323B34FD4FFB,,2,,,,,,,,,,,XXXX1111,Visa,,,,,,,,,,,,,,,,</directResponse></createCustomerProfileTransactionResponse>", txnAmount);
             LocalRequestObject.ResponseString = responseString;
             XmlSerializer serializer = new XmlSerializer(typeof(createCustomerProfileTransactionResponse));
             StringReader reader = new StringReader(responseString);
@@ -665,7 +667,7 @@ public void AuthorizeAndCaptureTest()
             string profileID = "24231938";
             string paymentProfileID = "22219473";
             Order order = new Order(profileID, paymentProfileID, "");
-            order.Amount = (decimal) 25.10;
+            order.Amount = txnAmount;
 
             IGatewayResponse actual = null;