Send the Vary header by default #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the default behaviour of the `Vary` header from opt-in to opt-out. There are still way too many problems with caching plugins and the plugin should work out of the box without having to tweak too much. /cc @snarfed
…utomattic/wordpress-activitypub into change/always-send-vary-header
11 tasks
obenland
approved these changes
May 2, 2025
pfefferle
added a commit
that referenced
this pull request
May 6, 2025
* Change default settings based on caching behaviour Change the default behaviour of the plugin based on the caching plugins that are installed. This PR is an extension to #1639 and #1638 * fix phpcs issues * seems to not properly work with the plugin so let's wait for the first that needs it. * fix whitespaces * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default behaviour of the
Varyheader from opt-in to opt-out.There are still way too many problems with caching plugins and the plugin should work out of the box without having to tweak too much.
/cc @snarfed
Proposed changes:
Varyheader setting totrueOther information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Improve compatibility with third-party caching plugins by sending a
Varyheader.