Skip to content

Checklist: Update option in case it exists. #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

obenland
Copy link
Member

@obenland obenland commented May 6, 2025

I ran into a problem in testing where the option wouldn't update. This fixes it for all cases (hopefully)

Proposed changes:

  • Use update_option rather than add_option.
  • Add helpful comments.
  • Merge args array.

@obenland obenland requested a review from pfefferle May 6, 2025 18:18
@obenland obenland self-assigned this May 6, 2025
@obenland obenland merged commit 8116bd4 into change/welcome-page May 6, 2025
11 checks passed
@obenland obenland deleted the update/profile-view branch May 6, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants