This repository was archived by the owner on Mar 16, 2023. It is now read-only.
Fix sdk send api #503
Merged
Fix sdk send api #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeandrews
approved these changes
Mar 20, 2020
Contributor
|
🎉 This PR is included in version 1.22.0 🎉 Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 0.18.1 🎉 Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.7.1 🎉 Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue that calling
zkAsset.sendwill fail for various reasons.Description
Wrong contract artifact for account registry
The new
confidentialTransferFromhas 6 parameters while the old one only has 5. Updating the contract artifacts fromBehaviour20200220toBehaviour20200305inconfig/contracts/developmentandconfig/contracts/productionfixes this.Invalid bytes value
The 6th parameter in
confidentialTransferFromwas assigned an empty string as default value. Should be0x.Wrong return data from MetaMaskService
The old
metamask.eip712.signProofapi in MetaMaskService returned{ signature }. It was changed to{ signature1, signature2 }. But the function in ui that calls this api was still catching data as{ signature }. So both signature1, signature2 were empty at the time we calledconfidentialTransferFrom, causing it to throw an error "sender does not have approval to spend input note".Types of changes
Bug fix (non-breaking change which fixes an issue)