Skip to content
This repository was archived by the owner on Sep 24, 2019. It is now read-only.

Added alternate methods for authentication #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HarvestingClouds
Copy link

Added methods with extensive comments to the samples to acquire the
authentication token via alternate methods. These methods include
authenticating using credential and also using a certificate. These
methods do not require any manual intervention and fetch the required token
completely programmatically.

Added methods with extensive comments to the samples to acquire the
authentication token via alternate methods. These methods include
authenticating using credential and also using a certificate. These
methods do not require manual intervention and fetch the required token
completely programmatically.
@acomsmpbot
Copy link
Contributor

No issues were found in this pull request.

@BryanLa
Copy link
Contributor

BryanLa commented Jun 15, 2016

@HarvestingClouds - thanks very much for your contribution. I will discuss w/some engineering folks and see if they way to include this in the sample. Either way, this PR will provide additional/useful code for others.

@tommysundling
Copy link

Any progress on this pull request? It would be very useful to have current samples on how to use the Azure Billing APIs. Thank you

@BryanLa
Copy link
Contributor

BryanLa commented Nov 28, 2016

Apologies for the delay on this. If I recall correctly, the preference was to bundle these into a separate sample with a separate confidential/web app AAD registration. The reason is because this is meant as a console sample which is considered a public client, and it wouldn't be good practice to demonstrate confidential/web client code (ie: exposing secrets) in this sample.

@tommysundling
Copy link

Appreciate the quick response. If there is no intention to updating the sample and keeping it up to date (=working) I would suggest that a note saying as much is made at the top of the readme file. That would help avoid confusion for people looking at the sample for a minimal effort. Just a friendly suggestion.

Regardless, thank you for responding.

@BryanLa
Copy link
Contributor

BryanLa commented Nov 28, 2016

Thanks @tommysundling.

Agree. As I mentioned earlier I'd like to leave this PR open for that reason, in case people are building a web client and want to see that type of client code.

Regarding the readme note, we will definitely keep it working if there is an API change that breaks it. Can you also confirm that you are NOT having problems with it? Just want to make sure we are not overlooking something that is supposed to be functioning, but isn't. I've tested multiple times and it works fine for me as the sample it was intended to be (ie: a public/console client).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants