Skip to content

bumping timer package #10916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

bumping timer package #10916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60bfc56
bumping timer package
brettsam Mar 7, 2025
f6bbaa4
release notes
brettsam Mar 7, 2025
8a2b1d6
improving flaky test
brettsam Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
- Allow sync trigger to happen in managed environment when `AzureWebJobsStorage` is not set (#10767)
- Fixing default DateTime bug with TimeZones in TimerTrigger (#10906)
- Adjusting the logic to determine the warmup call in placeholder simulation mode to align with the production flow (#10918)
- Fixing invalid DateTimes in status blobs when invoking via portal (#10916)
4 changes: 2 additions & 2 deletions src/WebJobs.Script/WebJobs.Script.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Expand Down Expand Up @@ -41,7 +41,7 @@
<PackageReference Include="Microsoft.Azure.WebJobs.Host.Storage" Version="5.0.1" />
<PackageReference Include="Microsoft.Extensions.Azure" Version="1.7.1" />
<PackageReference Include="Microsoft.Azure.AppService.Proxy.Client" Version="2.3.20240307.67" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions" Version="5.2.0-12282" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions" Version="5.2.0-12287" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Http" Version="3.2.0" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Timers.Storage" Version="1.0.0-beta.1" />
<PackageReference Include="Microsoft.Azure.WebJobs.Script.Abstractions" Version="1.0.4-preview" />
Expand Down
8 changes: 5 additions & 3 deletions test/WebJobs.Script.Tests.Integration/Management/InstanceManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
using Microsoft.Azure.WebJobs.Script.WebHost.Management.LinuxSpecialization;
using Microsoft.Azure.WebJobs.Script.WebHost.Models;
using Microsoft.Azure.WebJobs.Script.Workers.Rpc;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using Microsoft.WebJobs.Script.Tests;
Expand Down Expand Up @@ -967,16 +966,19 @@ public async Task Does_Not_Mount_Invalid_BYOS_Accounts()

var meshInitServiceClient = new Mock<IMeshServiceClient>(MockBehavior.Strict);

bool called = false;
meshInitServiceClient.Setup(client =>
client.MountCifs(Utility.BuildStorageConnectionString(account1, accessKey1, CloudConstants.AzureStorageSuffix), share1, targetPath1)).Returns(Task.FromResult(true));
client.MountCifs(Utility.BuildStorageConnectionString(account1, accessKey1, CloudConstants.AzureStorageSuffix), share1, targetPath1))
.Returns(Task.FromResult(true))
.Callback(() => called = true);

var instanceManager = new AtlasInstanceManager(_optionsFactory, _httpClientFactory, _scriptWebEnvironment, _environment,
_loggerFactory.CreateLogger<AtlasInstanceManager>(), new TestMetricsLogger(), meshInitServiceClient.Object,
_runFromPackageHandler, _packageDownloadHandler.Object);

instanceManager.StartAssignment(hostAssignmentContext);

await Task.Delay(TimeSpan.FromSeconds(0.5));
await TestHelpers.Await(() => called);

meshInitServiceClient.Verify(
client => client.MountCifs(Utility.BuildStorageConnectionString(account1, accessKey1, CloudConstants.AzureStorageSuffix), share1,
Expand Down