Skip to content

Conversation

apranaseth
Copy link
Member

@apranaseth apranaseth commented Sep 26, 2025

This is to enable worker indexing for Logic Apps workflow app kind behind an environment variable. The settings used by Logic Apps are "FUNCTIONS_INPROC_NET8_ENABLED": "1", "FUNCTIONS_WORKER_RUNTIME": "dotnet" and we are bringing up a "dotnet" worker.

resolves #11386

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 18:44
@apranaseth apranaseth requested a review from a team as a code owner September 26, 2025 18:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables worker indexing for Logic Apps when running in codeful mode behind an environment variable setting. The change allows Logic Apps to use the dotnet worker runtime with specific environment variables while maintaining backward compatibility with existing Logic Apps that don't use codeful mode.

  • Adds WORKFLOW_CODEFUL_ENABLED environment variable support to control codeful mode behavior
  • Modifies worker indexing logic to allow indexing for Logic Apps when codeful mode is enabled
  • Disables strict worker runtime validation for Logic Apps in codeful mode

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/WebJobs.Script/Environment/EnvironmentSettingNames.cs Adds new environment variable constant for Logic App codeful mode
src/WebJobs.Script/Environment/EnvironmentExtensions.cs Implements extension method to check if Logic App codeful mode is enabled
src/WebJobs.Script/Utility.cs Updates worker indexing logic to allow indexing for Logic Apps in codeful mode
src/WebJobs.Script/Host/ScriptHost.cs Disables worker runtime validation for Logic Apps in codeful mode

@surgupta-msft
Copy link
Contributor

surgupta-msft commented Sep 29, 2025

I have a few questions/comments related to this PR -

  • Do we need these changes in dev branch? My understanding is that Logic apps uses in-proc branch only. We may need for consistency purpose between dev and in-proc - but double checking this.
  • Could you please complete the PR checklist in the description and add to the release notes?
  • It would be helpful if you can create a github issue and provide context about the changes. I am not very clear about the ask and changes here. Please link github issue in the PR description.
  • Please add some tests too.

Let me know if you need help with any of these items, happy to assist.

@apranaseth
Copy link
Member Author

I have a few questions/comments related to this PR -

  • Do we need these changes in dev branch? My understanding is that Logic apps uses in-proc branch only. We may need for consistency purpose between dev and in-proc - but double checking this.
  • Could you please complete the PR checklist in the description and add to the release notes?
  • It would be helpful if you can create a github issue and provide context about the changes. I am not very clear about the ask and changes here. Please link github issue in the PR description.
  • Please add some tests too.

Let me know if you need help with any of these items, happy to assist.

Yeah we plan to use the out of proc model soon so wanted to keep these changes in sync. I have updated the checklist and added github issue and test.

Copy link
Member

@soninaren soninaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add log statements for better tracking. as mentioned in the in-proc PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable worker indexing for workflow app

3 participants