-
Notifications
You must be signed in to change notification settings - Fork 469
Enabling worker indexing for Logic Apps app kind behind an enviornment setting #11378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables worker indexing for Logic Apps when running in codeful mode behind an environment variable setting. The change allows Logic Apps to use the dotnet worker runtime with specific environment variables while maintaining backward compatibility with existing Logic Apps that don't use codeful mode.
- Adds
WORKFLOW_CODEFUL_ENABLED
environment variable support to control codeful mode behavior - Modifies worker indexing logic to allow indexing for Logic Apps when codeful mode is enabled
- Disables strict worker runtime validation for Logic Apps in codeful mode
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/WebJobs.Script/Environment/EnvironmentSettingNames.cs | Adds new environment variable constant for Logic App codeful mode |
src/WebJobs.Script/Environment/EnvironmentExtensions.cs | Implements extension method to check if Logic App codeful mode is enabled |
src/WebJobs.Script/Utility.cs | Updates worker indexing logic to allow indexing for Logic Apps in codeful mode |
src/WebJobs.Script/Host/ScriptHost.cs | Disables worker runtime validation for Logic Apps in codeful mode |
I have a few questions/comments related to this PR -
Let me know if you need help with any of these items, happy to assist. |
Yeah we plan to use the out of proc model soon so wanted to keep these changes in sync. I have updated the checklist and added github issue and test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add log statements for better tracking. as mentioned in the in-proc PR.
This is to enable worker indexing for Logic Apps workflow app kind behind an environment variable. The settings used by Logic Apps are "FUNCTIONS_INPROC_NET8_ENABLED": "1", "FUNCTIONS_WORKER_RUNTIME": "dotnet" and we are bringing up a "dotnet" worker.
resolves #11386
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information