-
Notifications
You must be signed in to change notification settings - Fork 44
Expose TableFragmentType
via a Replace flag
#74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 50.29% 52.35% +2.05%
==========================================
Files 28 30 +2
Lines 4096 4273 +177
==========================================
+ Hits 2060 2237 +177
+ Misses 1890 1877 -13
- Partials 146 159 +13
Continue to review full report at Codecov.
|
Overall looks good, just needs a test in statemachine_test.go |
@AsafMah Thanks for your review! I've added a simple test to statemachine_test.go. Could you help me review again? |
Co-authored-by: AsafMah <[email protected]>
@AsafMah Good suggestion, I have added the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Pull Request Description
This PR proposes a fix for #73 . Table fragments of type
DataReplace
should cause the existing result set to be replaced with new one; otherwise, the obtained query result may contain duplicated entries. To make users aware of this, this PR adds a flag calledReplace
in structRow
to indicate that the existing result set should be emptied before adding this row to the set.Future Release Comment
Breaking Changes:
The new
Replace
flag in structRow
should be handled to avoid duplicated entries in the result set. Adding the following code to handle theReplace
flag in theiter.Do
calls is recommended:Fixes:
TableFragmentType
(TableFragmentType == DataReplace
is not correctly handled #73)