Skip to content

Add GraphRbac new library and clone the existing to Version1_6 folder #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2019

Conversation

ankushbindlish2
Copy link
Member

No description provided.

@ankushbindlish2 ankushbindlish2 changed the title [Donotmerge] Add GraphRbac new library Add GraphRbac new library and clone the existing to Version1_6 folder Mar 27, 2019
@markcowl
Copy link
Member

@ankushbindlish2 This looks good. The next step is to ensure that updating the packages in the powershell repo causes no issues. To do this you would (1) generate a digned build using the ps-common-sign Jenkins job; (2) Create a PR that puts the packages in toold\LocalFeed and updates the reeferences.; (3) Once this passes we will merge this ps-common PR, push a new set of common packages to nuget, and update the powershell pr to use the newly published common packages

Now that this PR is ready, we can do this [later this week], but you would need to update your module to actually use the new generated classes.

@ankushbindlish2
Copy link
Member Author

ankushbindlish2 commented Mar 28, 2019

(1) generate a signed build using the ps-common-sign Jenkins job;

Jenkins job for this change : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-common-sign/ yields https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-common-sign/317/
Az.StorageSync package for INT : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell-Private/job/AzPsPri-Sign/58

(2) Create a PR that puts the packages in toold\LocalFeed and updates the references.;

@markcowl markcowl merged commit 25eccaa into Azure:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants