Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on the transition from using
DisableErrorRecordsPersistence
toEnableErrorRecordsPersistence
in theConfigKeysForCommon
class and theShouldRecordDebugMessages
method. The changes are made to improve the code's readability and to make the feature opt-in rather than opt-out.Key changes include:
src/Authentication.Abstractions/Models/ConfigKeysForCommon.cs
: Removed theDisableErrorRecordsPersistence
constant from theConfigKeysForCommon
class. TheEnableErrorRecordsPersistence
constant is now being used instead. This change is made to switch from an opt-out to an opt-in system for error record persistence.src/Common/AzurePSCmdlet.cs
: Modified theShouldRecordDebugMessages
method to use theEnableErrorRecordsPersistence
constant instead of theDisableErrorRecordsPersistence
constant. This change aligns with the modification inConfigKeysForCommon
and ensures consistency across the codebase.