Allow NetCore packages to depend on Newtonsoft.Json 9 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow packages to depend on Newtonsoft.Json 9
Update netframework dependcies on clientruntime
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.Management.Storage" Version="7.1.0-preview" /> |
There was a problem hiding this comment.
Why are these being removed?
There was a problem hiding this comment.
Because they are not actually used in the package. We use these dependencies to control the storage version used in the modules, I am instead moving these into the azure-powershell common dependcies just for those packages that need them. This is necessary to allow building cmdlets and cmdlet test packages that depend on newtonsoft.json 9
MiYanni
requested changes
Sep 13, 2018
src/Storage/Storage.Netcore.csproj
Outdated
| @@ -1,4 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <OmitJsonackage>true</OmitJsonackage> | |||
There was a problem hiding this comment.
Typo in tag. Should be OmitJsonPackage.
MiYanni
previously approved these changes
Sep 13, 2018
MiYanni
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.