-
Notifications
You must be signed in to change notification settings - Fork 4k
Update versions and changelog for 4.2.1 release #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl LGTM outside of minor changes that shouldn't affect release
ChangeLog.md
Outdated
* ServiceManagement | ||
- Fix issue with non-interactive user authentication (link)[https://github.com/Azure/azure-powershell/issues/4299] | ||
|
||
## 2017.07.17 - Version 4.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl duplicate section
src/Storage/ChangeLog.md
Outdated
@@ -21,6 +21,10 @@ | |||
|
|||
## Version 3.2.0 | |||
|
|||
## Version 3.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl weird duplication
@@ -12,7 +12,7 @@ | |||
# RootModule = '' | |||
|
|||
# Version number of this module. | |||
ModuleVersion = '0.9.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl do we care about updating the Netcore versions?
signing run here: http://azuresdkci.cloudapp.net/job/powershell-sign/1209/ |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines