Skip to content

Client-side telemetry is opt-in by default #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 8, 2017
Merged

Client-side telemetry is opt-in by default #4396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc0c059
Opt in user to telemetry by default, send HashMacAddress as a part of…
cormacpayne Aug 1, 2017
1bbc4df
Resolve review feedback
cormacpayne Aug 1, 2017
1b73dfc
Update HashMacAddress calculation
cormacpayne Aug 3, 2017
d4bbb8f
Remove usage of CheckIfInteractive method in base cmdlet classes
cormacpayne Aug 3, 2017
4aeb0d1
Fix failing Profile test
cormacpayne Aug 4, 2017
e7d65f3
Update Profile change log
cormacpayne Aug 4, 2017
33c51f7
Move environment variable declaration to test constructor from contro…
cormacpayne Aug 7, 2017
ff4bde9
Add extension methods to enable and disable data collection for tests
cormacpayne Aug 7, 2017
fa08219
Update failing Storage tests
cormacpayne Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move environment variable declaration to test constructor from contro… 
…ller
  • Loading branch information
@cormacpayne
cormacpayne committed Aug 7, 2017
commit 33c51f7def4df234fde167cbb3ee5a2ac00f96a6
3 changes: 3 additions & 0 deletions src/ResourceManager/Profile/Commands.Profile.Test/ContextCmdletTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
using Xunit;
using Xunit.Abstractions;
using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
using System;
using Microsoft.WindowsAzure.Commands.Common;

namespace Microsoft.Azure.Commands.ResourceManager.Profile.Test
{
Expand All @@ -42,6 +44,7 @@ public ContextCmdletTests(ITestOutputHelper output)
AzureSession.Instance.DataStore = dataStore;
commandRuntimeMock = new MockCommandRuntime();
AzureSession.Instance.AuthenticationFactory = new MockTokenAuthenticationFactory();
Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion src/ResourceManager/Profile/Commands.Profile.Test/ProfileController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ private void RunPsTestWorkflow(
helper.RMResourceModule,
helper.RMResourceManagerStartup,
helper.RMInsightsModule);
Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");

try
{
if (scriptBuilder != null)
Expand Down