Skip to content

[DataFactory] Add Integration Runtime Cmdlets. #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 5, 2017
Merged

[DataFactory] Add Integration Runtime Cmdlets. #5060

merged 12 commits into from
Dec 5, 2017

Conversation

zhangyd2015
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Constants.IntegrationRuntimeNodeIp,
DefaultParameterSetName = ParameterSetNames.ByIntegrationRuntimeName),
OutputType(typeof(IntegrationRuntimeNodeIpAddress))]
public class GetAzureDataFactoryIntegrationRuntimeNodeIpCommand : IntegrationRuntimeContextBaseCmdlet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my response in the review: https://github.com/Azure/azure-powershell-pr/wiki/ADF-V2-Integration-Runtime-New-Cmdlets-(December-2017)-Notes#response

If this is an expensive call, then you should provide an option switch on the existing Get-* cdlet to include this ifnormation, ratehr than havign a new cmdlet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it as your comments. Thanks.

[Parameter(
Mandatory = false,
HelpMessage = Constants.HelpDontAskConfirmation)]
public SwitchParameter Force { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include Force here, as you are doing thsi every time. Instead, simply implement ShouldProcess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Force.


[Parameter(
Mandatory = false, HelpMessage = Constants.HelpDontAskConfirmation)]
public SwitchParameter Force { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force should not be necessary here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Microsoft.Azure.Management.DataFactory" version="0.2.1-preview" targetFramework="net452" />
<package id="Microsoft.Azure.Management.DataFactory" version="0.3.0-preview" targetFramework="net452" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be cleaned up. ActiveDirectory and AUthentication are not required. If you use WindowsAzure.Storage and its depednecies and the other assemblies, then these need to be included in the RequiredAssemblies in your psd1 file. If you do not, then these should be removed form here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned.

…onRuntimeNodeIp into Get-AzureRmDataFactoryV2IntegrationRuntimeNode
@maddieclayton
Copy link
Contributor

@zhangyd2015 Some merge conflicts have come up - can you please resolve these?

@markcowl markcowl removed their assignment Dec 4, 2017
@markcowl
Copy link
Member

markcowl commented Dec 4, 2017

@markcowl markcowl merged commit 6568dea into Azure:preview Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants