-
Notifications
You must be signed in to change notification settings - Fork 4k
[DataFactory] Add Integration Runtime Cmdlets. #5060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sync from Azure repo
Sync from upstream
Sync from upstream.
Constants.IntegrationRuntimeNodeIp, | ||
DefaultParameterSetName = ParameterSetNames.ByIntegrationRuntimeName), | ||
OutputType(typeof(IntegrationRuntimeNodeIpAddress))] | ||
public class GetAzureDataFactoryIntegrationRuntimeNodeIpCommand : IntegrationRuntimeContextBaseCmdlet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my response in the review: https://github.com/Azure/azure-powershell-pr/wiki/ADF-V2-Integration-Runtime-New-Cmdlets-(December-2017)-Notes#response
If this is an expensive call, then you should provide an option switch on the existing Get-* cdlet to include this ifnormation, ratehr than havign a new cmdlet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it as your comments. Thanks.
[Parameter( | ||
Mandatory = false, | ||
HelpMessage = Constants.HelpDontAskConfirmation)] | ||
public SwitchParameter Force { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not include Force here, as you are doing thsi every time. Instead, simply implement ShouldProcess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed Force.
|
||
[Parameter( | ||
Mandatory = false, HelpMessage = Constants.HelpDontAskConfirmation)] | ||
public SwitchParameter Force { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force should not be necessary here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@@ -1,6 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<packages> | |||
<package id="Microsoft.Azure.Management.DataFactory" version="0.2.1-preview" targetFramework="net452" /> | |||
<package id="Microsoft.Azure.Management.DataFactory" version="0.3.0-preview" targetFramework="net452" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be cleaned up. ActiveDirectory and AUthentication are not required. If you use WindowsAzure.Storage and its depednecies and the other assemblies, then these need to be included in the RequiredAssemblies in your psd1 file. If you do not, then these should be removed form here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned.
…onRuntimeNodeIp into Get-AzureRmDataFactoryV2IntegrationRuntimeNode
@zhangyd2015 Some merge conflicts have come up - can you please resolve these? |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines