Skip to content

Update Build tools for adls data plane #5419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 606 commits into from
Feb 3, 2018

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Feb 1, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

HaoQian-MS and others added 30 commits January 9, 2018 19:35
Revert BreakingCHangeIssues.csv
This line: (48) PS C:\> Update-AzureRmVM -ResourceGroupName "ResourceGroup11" -Name "VirtualMachine07" -VM $VirtualMachine
Needs to be this (as there is not any -Name parameter for this command): 
PS C:\> Update-AzureRmVM -ResourceGroupName "ResourceGroup11" -VM $VirtualMachine
Please also update the following MS pages: 
https://docs.microsoft.com/en-us/powershell/module/azurerm.compute/add-azurermvmnetworkinterface?view=azurermps-5.1.1
to match https://docs.microsoft.com/en-us/powershell/module/azurerm.compute/update-azurermvm?view=azurermps-5.1.1
Attempting to fix this per Amit Bapat. 
"Backup and Restore are INVALID values for -KeyOps parameter and should be removed."
If this is not the right way to update this article please let me know. I am just now taking over these powershell articles for KeyVault
The Update using PSRoleDefinitionObject example used the New-AzureRmRoleDefinition command to update the role, since you are updating an existing role this fails. You need to use Set-AzureRmRoleDefinition, which is what this article is detailing.
Correct mistake with PSRoleDefinitionObject  example
Update Add-AzureRmVMNetworkInterface.md
Add -AsJob parameter to websites cmdlets
Add alias from Get-AzureRmProviderOperation to Get-AzureRmResourceProviderAction
cormacpayne and others added 26 commits January 30, 2018 10:07
…nto preview

# Conflicts:
#	src/ResourceManager/EventGrid/ChangeLog.md
…into preview

# Conflicts:
#	src/ResourceManager/EventGrid/ChangeLog.md
…nto SBGeoDR_2017

# Conflicts:
#	src/ResourceManager/ServiceBus/ChangeLog.md
…nto SBGeoDR_2017

# Conflicts:
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
Update version of EventHub SDK used in EventGrid test project
Correct error in ResourceGroup Parameter Description
Update of Set-AzureRmVMOsDisk to support managed OS disk swap
Update EventHub SDK version used in IotHub tests
EventHubs: updated online version links in markdown files
EventGrid: Updated to use the latest version of the .NET SDK
@markcowl
Copy link
Member Author

markcowl commented Feb 2, 2018

@markcowl markcowl merged commit b614b69 into Azure:adls-data-plane Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.