-
Notifications
You must be signed in to change notification settings - Fork 4k
Update Build tools for adls data plane #5419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert BreakingCHangeIssues.csv
This line: (48) PS C:\> Update-AzureRmVM -ResourceGroupName "ResourceGroup11" -Name "VirtualMachine07" -VM $VirtualMachine Needs to be this (as there is not any -Name parameter for this command): PS C:\> Update-AzureRmVM -ResourceGroupName "ResourceGroup11" -VM $VirtualMachine Please also update the following MS pages: https://docs.microsoft.com/en-us/powershell/module/azurerm.compute/add-azurermvmnetworkinterface?view=azurermps-5.1.1 to match https://docs.microsoft.com/en-us/powershell/module/azurerm.compute/update-azurermvm?view=azurermps-5.1.1
Attempting to fix this per Amit Bapat. "Backup and Restore are INVALID values for -KeyOps parameter and should be removed." If this is not the right way to update this article please let me know. I am just now taking over these powershell articles for KeyVault
The Update using PSRoleDefinitionObject example used the New-AzureRmRoleDefinition command to update the role, since you are updating an existing role this fails. You need to use Set-AzureRmRoleDefinition, which is what this article is detailing.
Update Add-AzureKeyVaultKey.md
Correct mistake with PSRoleDefinitionObject example
Update Add-AzureRmVMNetworkInterface.md
Add -AsJob parameter to websites cmdlets
…using Set-AzureRmContext
Add alias from Get-AzureRmProviderOperation to Get-AzureRmResourceProviderAction
…nto preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md
…into preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md
…nto SBGeoDR_2017 # Conflicts: # src/ResourceManager/ServiceBus/ChangeLog.md
…nto SBGeoDR_2017 # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
Update version of EventHub SDK used in EventGrid test project
Correct error in ResourceGroup Parameter Description
Update of Set-AzureRmVMOsDisk to support managed OS disk swap
Update EventHub SDK version used in IotHub tests
ServiceBus: Geo DR Updates
EventHubs: updated online version links in markdown files
EventGrid: Updated to use the latest version of the .NET SDK
…t for preview modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines