Skip to content

[Insights] Using SDK 20.1-preview with some fixes. Fixing reported issues with the Diagnostic Settings cmdlets #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

gucalder
Copy link
Contributor

Description

  • Using DSK 0.20.1-preview to fix some issues with the Swagger specs (check this file for details about the changes https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/Monitor/changelog.md)
  • All cmdlets for Diagnostic Settings were modified to remain backwards compatible, but to not fail if the legacy diagnostic setting (called service) is not present. Now it is possible to list all the diagnostic settings for a resource, it is possible to create a new diagnostic setting even if there is not "service" diagnostic setting defined yet. The remove cmdlet removes the diagnostic settings, regardless of name, if there is only one.

Checklist

@MiYanni MiYanni changed the base branch from preview to release-2018-08-24 August 22, 2018 21:34
@markcowl
Copy link
Member

@gucalder Closing in favor of #7021

@markcowl markcowl closed this Aug 22, 2018
markcowl added a commit that referenced this pull request Aug 23, 2018
[Insights] Using SDK 20.1-preview with some fixes. Fixing reported issues with the Diagnostic Settings cmdlets #6998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants