[RecoveryServices] Adding support for restore item for azure file share #7681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonfly91
previously approved these changes
Oct 29, 2018
markcowl
requested changes
Oct 29, 2018
| [Parameter(Mandatory = true, Position = 3, ParameterSetName = AzureFileParameterSet, | ||
| HelpMessage = ParamHelpMsgs.RestoreFS.ResolveConflict)] | ||
| [ValidateNotNullOrEmpty] | ||
| public RestoreFSResolveConfictOption ResolveConflict { get; set; } |
There was a problem hiding this comment.
Also, please remove the position setting for all positions >= 3
| /// <summary> | ||
| /// Source File Path of the file to be recovered | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, Position = 4, ParameterSetName = AzureFileParameterSet, |
| /// <summary> | ||
| /// Source File Type of the file to be recovered | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, Position = 5, ParameterSetName = AzureFileParameterSet, |
| /// <summary> | ||
| /// Target storage account name where the disks need to be recovered | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, Position = 6, ParameterSetName = AzureFileParameterSet, |
| /// <summary> | ||
| /// The target file share name to which the files are restored. | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, Position = 7, ParameterSetName = AzureFileParameterSet, |
| /// <summary> | ||
| /// The target folder name to which the files are restored. | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, Position = 8, ParameterSetName = AzureFileParameterSet, |
| "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer." |
| "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer." |
markcowl
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/113
Checklist
CONTRIBUTING.mdplatyPSmodule