Skip to content

Conversation

@Jinming-Hu
Copy link
Member

@Jinming-Hu Jinming-Hu commented Jul 25, 2023

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@Jinming-Hu Jinming-Hu self-assigned this Jul 25, 2023
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 25, 2023
@Jinming-Hu
Copy link
Member Author

/azp run cpp - storage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

microzchang
microzchang previously approved these changes Jul 25, 2023
@Jinming-Hu
Copy link
Member Author

/azp run cpp - storage

@Jinming-Hu Jinming-Hu requested a review from microzchang July 26, 2023 12:09
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Jinming-Hu
Copy link
Member Author

@microzchang I made some code changes, can you review this PR again?

@Jinming-Hu Jinming-Hu merged commit e77eff6 into Azure:main Jul 27, 2023
@Jinming-Hu Jinming-Hu deleted the test-impr branch July 27, 2023 03:25
microzchang added a commit that referenced this pull request Jul 27, 2023
* Set DOCKER_BUILDKIT to 1 in stress deploy image build (#4815)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Make x509 certificate script from azure-sdk-for-net common to repos (#4817)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* improve test proxy sanitizers (#4796)

* Storage test cases improvements (#4819)

* soft delete test

* enable setTierCold

* IsConnectionReuse in record-playback mode

* DISABLED_UploadPagesFromUriCrc64AccessCondition

* update recording assets

* ClientSecretCredentialWorks works in record-playback mode

* ServiceContainerSasPermissions and ServiceBlobSasPermissions work in record-playback mode

* BlobServiceClientTest.UserDelegationKey works in record-playback mode

* update recordings

* f

---------

Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: JinmingHu <[email protected]>
@Jinming-Hu Jinming-Hu mentioned this pull request Aug 14, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files) test-enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants