Skip to content

Conversation

@gearama
Copy link
Contributor

@gearama gearama commented Apr 11, 2024

…, cleanup the recording

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title to "Make tests LIVEONLY"

Also open an issue if we need to revisit to see if we can bring it back into recorded

@gearama gearama changed the title disable download tests , the cert was in another form in both of them… Liveonly tests , the cert was in another form in both of them… Apr 11, 2024
@gearama
Copy link
Contributor Author

gearama commented Apr 11, 2024

filed #5522

@ahsonkhan
Copy link
Contributor

/azp run cpp - keyvault

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gearama gearama merged commit e2f0e0a into Azure:main Apr 12, 2024
@gearama gearama deleted the kvRecordings branch April 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants