-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Verifysdist and Verifywhl without Tox #43126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scbedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will handle these and get em across the finish line for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new verification commands verifywhl and verifysdist to the Azure SDK tooling, providing an alternative to the existing tox-based workflow. The changes implement comprehensive package validation including wheel structure verification, source distribution checks, metadata compatibility validation, and type annotation configuration verification.
Key changes:
- Adds standalone wheel and source distribution verification tools
- Implements metadata compatibility checking against prior versions
- Validates proper py.typed configuration for type annotations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| eng/tools/azure-sdk-tools/azpysdk/verify_whl.py | New module implementing wheel verification including root directory validation and metadata compatibility checks |
| eng/tools/azure-sdk-tools/azpysdk/verify_sdist.py | New module implementing source distribution verification including directory structure and py.typed configuration validation |
| eng/tools/azure-sdk-tools/azpysdk/main.py | Registers the new verification commands in the main CLI parser |
| doc/tool_usage_guide.md | Documents the new verifywhl and verifysdist commands with usage examples |
|
@JennyPng @swathipil is updating this check over in #43188 , you might want to hold off merging this to fold those changes in. |
scbedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold off on merging till Swathi's PR goes in. Then fold those changes in IMO, but I won't block this. If you want to just submit another PR updating after Swathi is done, good with that too!
The copilot comments strike me as right. It might be working as-is because we're in cwd context of the target folder by accident.
Description
#42883