Skip to content

Conversation

@JennyPng
Copy link
Member

Description

#42883

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will handle these and get em across the finish line for you.

@JennyPng JennyPng marked this pull request as ready for review October 2, 2025 20:55
Copilot AI review requested due to automatic review settings October 2, 2025 20:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new verification commands verifywhl and verifysdist to the Azure SDK tooling, providing an alternative to the existing tox-based workflow. The changes implement comprehensive package validation including wheel structure verification, source distribution checks, metadata compatibility validation, and type annotation configuration verification.

Key changes:

  • Adds standalone wheel and source distribution verification tools
  • Implements metadata compatibility checking against prior versions
  • Validates proper py.typed configuration for type annotations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
eng/tools/azure-sdk-tools/azpysdk/verify_whl.py New module implementing wheel verification including root directory validation and metadata compatibility checks
eng/tools/azure-sdk-tools/azpysdk/verify_sdist.py New module implementing source distribution verification including directory structure and py.typed configuration validation
eng/tools/azure-sdk-tools/azpysdk/main.py Registers the new verification commands in the main CLI parser
doc/tool_usage_guide.md Documents the new verifywhl and verifysdist commands with usage examples

@scbedd
Copy link
Member

scbedd commented Oct 3, 2025

@JennyPng @swathipil is updating this check over in #43188 , you might want to hold off merging this to fold those changes in.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging till Swathi's PR goes in. Then fold those changes in IMO, but I won't block this. If you want to just submit another PR updating after Swathi is done, good with that too!

The copilot comments strike me as right. It might be working as-is because we're in cwd context of the target folder by accident.

@JennyPng JennyPng merged commit edfa280 into Azure:main Oct 8, 2025
19 checks passed
@JennyPng JennyPng deleted the jennypng-verifysdist branch October 8, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants