Fix(logout) : Logout not working when deployed

[ntatoud]

Describe your changes

closes #481
Make the logout mutation async so that it can be awaited properly

Question : Is there still a point to making the optimistic update ?

The code before : (await has no effect)

This lead to :
Redirection happening before the logout and triggering checkAuthenticated before the end of logout.
Reminder : checkAuthenticated sets a new auth cookie.

What happend before on the logout page :

1. Call logout
2. Redirection
3. Call checkAuthenticated (user still in context)
4. Suppression of the cookie
5. Cookie set again in checkAuthenticated
6. User not logged out

After the fix:

Checklist

• I performed a self review of my code
• I ensured that everything is written in English
• I tested the feature or fix on my local environment

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
start-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2024 4:10pm

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ivan-dalmet]

Nice catch.
Yes I think we still need the code to update the check value because else the value "true" will still be in the cache. We could do an invalidate query but we know the value.