fixes arguments attributes in the callsites plugin
#1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attributes are assigned to a newly created synthetic argument term in the callsites plugin, we don't take into consideration attributes from the original argument term. This PR fixes this and now all the attributes from origin argument term are assigned to the new one.
ivg
requested changes
Jan 24, 2020
plugins/callsites/callsites_main.ml
Outdated
| Term.set_attr t2 Term.origin (Term.tid t1) |> | ||
| transfer_attr Disasm.insn t1 |> | ||
| transfer_attr address t1 | ||
| let transfer_attrs origin_arg call arg = |
There was a problem hiding this comment.
The arg argument is not an arg it is a def.
plugins/callsites/callsites_main.ml
Outdated
| transfer_attr Disasm.insn t1 |> | ||
| transfer_attr address t1 | ||
| let transfer_attrs origin_arg call arg = | ||
| let arg = Term.with_attrs arg (Term.attrs origin_arg) in |
There was a problem hiding this comment.
move this code to the def_of_arg function, leave everything else intact.
ivg
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attributes are assigned to a newly created synthetic argument term
in the
callsitesplugin, we don't take into consideration attributesfrom the original argument term. This PR fixes this and now all the
attributes from origin argument term are assigned to the new one.