fixes the glibc runtime check #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Once #1187 goes into master, I will rebase this PR. |
We are not using is-executable for the glibc runtime check though, as we have a more precise check now - we can look for the name reference of __libc_start_main and if it is there insert it. fixes BinaryAnalysisPlatform#1130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1187 (on which this PR is based) we have full information about name references so we can devise a precise check for whether we need to insert the
__libc_start_mainfunction, i.e., we can just look if it is referenced in the binary.This PR also adds
formatandis-executableproperties both to the OGRE representation and to the Core Theory. They are not used for the glibc runtime check (though meant to be used originally), but deem useful.Fixes #1130.