Fix PowerShell fingerprints #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate a dummy fingerprint and verify that the expected environment variable is set correctly.
The test that overrides the language in the recipe was not actually executed.
When the default language is set to PowerShell, any script without the language suffix should apply to PowerShell. Specifically, the "fingerprintScript" should be executed as PowerShell script if "fingerprintScriptPwsh" is not set. This was not working, though.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 88.20% 88.28% +0.07%
==========================================
Files 46 46
Lines 14493 14493
==========================================
+ Hits 12784 12795 +11
+ Misses 1709 1698 -11
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.