Fix gunzip extract #650
Merged
Fix gunzip extract #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class was not derived from unittest.TestCase, meaning that no tests were actually executed. Fix that and also fix the testcases themselves because they had some small errors.
With the introduction of the separateDownload policy, the file name of downloaded file is not necessarily in the workspace anymore. Consistently use the destination file name everywhere. Otherwise the log messages are misleading in case the policy is on the new behaviour.
If the download is not an archive but a single gz/xz compressed file, the extractor will output the result to stdout. In this case the output file must be opened only after we are sure that the extraction actually happens. Previously, the output file was opened for writing unconditionally. This truncated the file and would leave it in this state if the extraction was skipped.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
==========================================
- Coverage 88.98% 88.97% -0.01%
==========================================
Files 50 50
Lines 16112 16113 +1
==========================================
Hits 14337 14337
- Misses 1775 1776 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Works for me again. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking a deterministic gz/xz URL SCM twice lead to a truncated output file.