Skip to content

Conversation

@icedieler
Copy link
Contributor

Unify the description of the option syntax. Add the long option where one is available.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (c8a6f87) to head (cb94a1a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files          50       50           
  Lines       16116    16116           
=======================================
  Hits        14340    14340           
  Misses       1776     1776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jkloetzke jkloetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synopsis of the manpages is a verbatim copy of the respective output of bob <command> -h | cat. I would like to keep it this way, even if we do not show the long variant of arguments with short options. Otherwise, keeping the synopsis in sync will get increasingly harder.

Comment on lines +22 to +23
[-q, --quiet] [-v, --verbose] [--no-logfiles] [-D VAR=VALUE] [-c CONFIGFILE]
[-lc LAYERCONFIG] [-e NAME] [-E] [-M VAR=VALUE] [--upload]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not just manually fix the documentation but also the help text (bob build -h). For that, the argparse module allows to set the "metavar". You could add metavar="VAR=VALUE" to the relevant arguments in pym/bob/cmds/build/build.py. That way also the online help text is correct.

Unify the description of the option syntax. Add the long option where
one is available and sync the description with the output of

  `bob build -h`
@icedieler
Copy link
Contributor Author

Thanks @jkloetzke for the helpful review. In the new pull request I made sure to have both the command help and the manpage in sync and at least don't worsen the situation.

@jkloetzke jkloetzke merged commit f958833 into BobBuildTool:master Jul 23, 2025
11 checks passed
@jkloetzke
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants