Skip to content

Added compatibility with Symfony 4 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2018
Merged

Added compatibility with Symfony 4 #12

merged 4 commits into from
Jan 15, 2018

Conversation

marcortola
Copy link
Contributor

No description provided.

@BrainMaestro
Copy link
Owner

Hi @novecode. Thanks for the contribution. Can you explain why you made this change?

@marcortola
Copy link
Contributor Author

Hi, I decided to do this PR because it was impossible to require composer-git-hooks in projects that were already using symfony/console v4.0.

@BrainMaestro
Copy link
Owner

Okay, fair enough. what of removing 7.0 from travis

@marcortola
Copy link
Contributor Author

symfony/console ^4.0 requires php ^7.1. It's why Travis build was failing:

    - Installation request for symfony/console v4.0.3 -> satisfiable by symfony/console[v4.0.3].
    - symfony/console v4.0.3 requires php ^7.1.3 -> your PHP version (7.0.25) does not satisfy that requirement.

Perhaps best solution would be change .travis.yml to something like this:

language: php

matrix:
  include:
    - php: 7.0
      env: DEPS=dev SYMFONY_CONSOLE_VERSION='3.2.*'
    - php: 7.1
      env: DEVS=dev SYMFONY_CONSOLE_VERSION='4.0.*'

before_install:
  - composer require --no-update "symfony/console:${SYMFONY_CONSOLE_VERSION}";

install:
  - composer install

@BrainMaestro
Copy link
Owner

Okay, can you do that instead?

@marcortola
Copy link
Contributor Author

marcortola commented Jan 15, 2018

Yes, I have done it in this commit: https://github.com/BrainMaestro/composer-git-hooks/pull/12/commits/32d67af44fbe6cb952dfc59b76dc8a25b032bca7

Travis will check now PHP 5.6, 7.0 and 7.1 versions. I have added a composer.json validation too.

@BrainMaestro
Copy link
Owner

I don't think this project is compatible with PHP 5.6. It has PHP 7 only features. Also, the travis build isn't being triggered for some reason

@BrainMaestro BrainMaestro merged commit 63eba02 into BrainMaestro:master Jan 15, 2018
@BrainMaestro
Copy link
Owner

@novecode thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants