Add support for Windows #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For developers who use JetBrains IntellJIDEA.
tests/ListCommandTest.php
Outdated
| @@ -37,7 +37,13 @@ public function it_lists_hooks_that_exist() | |||
| public function it_uses_a_different_git_path_if_specified() | |||
| { | |||
| $gitDir = 'test-git-dir'; | |||
| passthru("mkdir -p {$gitDir}/hooks"); | |||
|
|
|||
| $command = "mkdir -p {$gitDir}/hooks"; | |||
There was a problem hiding this comment.
You know what, could we just use the mkdir function? I should've done that in the first place. It would be much better.
|
Hey thanks for doing this! It looks pretty good. |
|
Thank you for your feedback. I have adjusted everything so far that only native PHP functions will be used in future. |
|
Hey that's way better than I thought. Thanks for this |
glensc
reviewed
Jun 2, 2019
| public function it_adds_shebang_to_hooks_on_windows() | ||
| { | ||
| if(strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN') | ||
| $this->markTestSkipped('This test is only relevant on windows. You\'re running Linux.'); |
There was a problem hiding this comment.
no, I am not. I'm on macOS ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will:
.gitignorefor JetBrain userspassthrusrc/Commands/AddCommand.phpto usefindstron windows instead ofgrep