Skip to content

Conversation

@samijaber
Copy link
Contributor

@samijaber samijaber commented Jan 19, 2024

Description

Vue SDK:

Fix CSS imports:

  • add a /nuxt subpath export for a Nuxt module. Currently, it handles importing CSS, and is used like so:
// nuxt.config.js
export default defineNuxtConfig({
  modules: ['@builder.io/sdk-vue/nuxt'],
});
  • bring back /css subpath export. This is used internally by the Nuxt module, but also allows more flexibility for customers to import CSS as they see fit.
  • remove CSS imports from server bundles, as they cause errors due to invalid extensions.
  • add sideEffects array to package.json for webpack.

@samijaber samijaber requested review from a team as code owners January 19, 2024 18:32
@samijaber samijaber requested review from teleaziz and removed request for a team January 19, 2024 18:32
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 4d9ce17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@builder.io/sdk-vue Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-nextjs Patch
@builder.io/sdk-qwik Patch
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nextjs-sdk-example ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 6:32pm
qwik-city-sdk-example ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 6:32pm
svelte-vite-example ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 6:32pm

@samijaber samijaber merged commit 2821f68 into BuilderIO:main Jan 19, 2024
@samijaber samijaber deleted the fix/vue-sdk-nuxt-css branch January 19, 2024 19:12
samijaber added a commit that referenced this pull request Apr 12, 2024
## Description

- remove all vue3 code
- Backport #2929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nuxt] Unknown file extension ".css"

1 participant