fix[angular-gen2]: add angular 19 ssr e2e and fix hydration errors #3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 666cc89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 666cc89.
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
@samijaber can you please take a look |
samijaber
approved these changes
Jan 23, 2025
| /** | ||
| * Angular doesn't support hydration for components created dynamically. | ||
| * Refer: https://angular.dev/errors/NG0503 | ||
| * GitHub issue: https://github.com/angular/angular/issues/51798 |
Contributor
There was a problem hiding this comment.
Does this issue resolve content duplication as well like https://builder-io.atlassian.net/browse/ENG-8042 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the hydration error thrown from angular for using ngComponentOutlet, adds angular-19-ssr to e2e and an example of how users can override fetch to use HTTP client from angular that should help in caching HTTP requests
Jira
https://builder-io.atlassian.net/browse/ENG-7946
https://builder-io.atlassian.net/browse/ENG-7945
https://builder-io.atlassian.net/browse/ENG-7665
Screenshot
If relevant, add a screenshot or two of the changes you made.