Header color change, fixes long list click #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opticod
force-pushed
the
bug-fixes
branch
3 times, most recently
from
a3993ce to
6eea6bd
Compare
opticod
reviewed
Feb 8, 2017
There was a problem hiding this comment.
@akmittal006, Thanks for these changes, but it looks like @vishwesh3 is also working for issue #364. Can you please remove the third fix from this PR, so that we can merge it.
Note: Squash your commits into one , Thank you
Closed
akmittal006
force-pushed
the
bug-fixes
branch
2 times, most recently
from
2709181 to
fc8fad6
Compare
|
@opticod it is done.
|
opticod
requested changes
Mar 14, 2017
| private static final int TYPE_HEADER = 0; | ||
| private static final int TYPE_ITEM = 1; | ||
| private final Context context; | ||
| private static Context context; |
There was a problem hiding this comment.
Using static field for Context variable will lead to memory leak. You can find many article on memory leak through static fields in web.
Can you come up with different approach for this?
| private static final int TYPE_HEADER = 0; | ||
| private static final int TYPE_ITEM = 1; | ||
| private final Context context; | ||
| private static Context context; |
|
@opticod I have made the changes. Thanks for reviewing. |
opticod
approved these changes
Mar 14, 2017
There was a problem hiding this comment.
Thanks @akmittal006 Its looking as well as working great. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a UI update which includes following:
change of header color based on type of template selected. Provides more continuity and feel to app.
Refactors some code
fixes Selecting and unselecting items #364