feat(mcp): Support custom cmd allow list for mcp server #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Signed-off-by: Adam Tao <[email protected]>
tcx4c70
force-pushed
the
feat/mcp-allow-list
branch
from
d3df12a to
a23e340
Compare
willydouhard
requested changes
Mar 18, 2025
backend/chainlit/server.py
Outdated
| @@ -762,7 +762,7 @@ async def project_settings( | |||
| config.features.audio.enabled = True | |||
|
|
|||
| if config.code.on_mcp_connect: | |||
| config.features.mcp = True | |||
| config.features.mcp.enabled = True | |||
There was a problem hiding this comment.
we could rely on the config value instead of the decorator presence
backend/chainlit/mcp.py
Outdated
| @@ -47,22 +50,24 @@ def validate_mcp_command(command_string: str): | |||
| # Look for the actual executable in the command | |||
| executable = None | |||
| executable_index = None | |||
| allowed_executables = config.features.mcp.stdio_executable_allow_list or [ | |||
There was a problem hiding this comment.
let's make those the default config values (in the config generation) and not hardcode them
backend/chainlit/config.py
Outdated
| @dataclass | ||
| class MCPFeature(DataClassJsonMixin): | ||
| enabled: bool = False | ||
| stdio_executable_allow_list: Optional[list[str]] = None |
There was a problem hiding this comment.
i would love to add transport config here. default would be ["stdio", "sse"], that way developers could refuse to use stdio servers for security reasons
willydouhard
requested changes
Mar 20, 2025
| @@ -1109,12 +1106,24 @@ async def connect_mcp( | |||
| exit_stack = AsyncExitStack() | |||
|
|
|||
| if payload.clientType == "sse": | |||
| if not config.features.mcp.sse.enabled: | |||
There was a problem hiding this comment.
I think we are missing a check on config.features.mcp.enabled. It seems like it is never checked and it could be false and sse could be enabled. in that case we should have failed earlier
Signed-off-by: Adam Tao <[email protected]>
* origin/main: feat: rework sidebar to support canvas (Chainlit#2034) Willy/starter command (Chainlit#2027) Added tags tracing on LangChain tracer (Chainlit#2026) chore: prepare release (Chainlit#2025)
notlaedri
pushed a commit
to notlaedri/chainlit
that referenced
this pull request
May 5, 2025
* feat(mcp): Support custom cmd allow list for mcp server Signed-off-by: Adam Tao <[email protected]> * feat(mcp): Support enable/disable sse/stdio mcp * fix: Check config.features.mcp.enabled Signed-off-by: Adam Tao <[email protected]> --------- Signed-off-by: Adam Tao <[email protected]>
hazemHany09
pushed a commit
to InfomineoGithub/chainlit
that referenced
this pull request
May 7, 2025
* feat(mcp): Support custom cmd allow list for mcp server Signed-off-by: Adam Tao <[email protected]> * feat(mcp): Support enable/disable sse/stdio mcp * fix: Check config.features.mcp.enabled Signed-off-by: Adam Tao <[email protected]> --------- Signed-off-by: Adam Tao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mcp servers are implemented using compiled language (such as go), and can't run via
npxoruvx. This PR supports to custom allow list for the commands to run mcp servers.