Added entry.mode and entry.strmode #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. There's only one thing missing: tests. I'm writing those and then I'll upload the new version to PyPI. |
Changaco
added a commit
that referenced
this pull request
Feb 6, 2015
Added entry.mode and entry.strmode
|
Done, version 1.1 is up on https://pypi.python.org/pypi/libarchive-c. |
|
Very good. Re: test - I did test my change in my test script, but have to On Fri, Feb 6, 2015 at 12:11 PM, Changaco [email protected] wrote:
|
Changaco
added a commit
that referenced
this pull request
Nov 29, 2016
Added entry.mode and entry.strmode
zeroos
referenced
this pull request
in zeroos/python-libarchive-c
Dec 15, 2016
Add entry from memory hacked version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added entry.mode and entry.strmode.
What does it take to make the changes become available such that one can run 'pip install libarchive-c' and pull those diffs :-) I should probably read up on this...
Thanks
Christian