Better support of links #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added support for issym for symlinks * fixed ArchiveEntry.islnk that was providing symlink info instead of hardlink to keep the same API as tarfile.TarInfo * Added support for linkpath for all link types * Added tests to verify that Entries data match tarfile.TarInfo data for the same archive
* path and name aliased to pathname * linkpath and linkname aliased
* test with trick tar from the CPython test suite
* tar and zips with entries of unknown/non unicode encoding
* use only the non-"_w" libarchive functions for paths and links * improved tests by base64 encoding paths
* win FS is UTF-encoded: sometimes only wide paths are returned These end up being unicode python strings and we convert then back to bytes
- refactors the tests - uses surrogate encoding instead of base64 - drops the OS-specific logic: we're only reading archives, if the result isn't consistent across platforms then it's a bug
|
@pombredanne Any idea about the remaining test failure? |
|
The error doesn't occur on my system with a vanilla libarchive 3.1.2, so the problem is in the Travis environment. |
|
any plans to merge this ?? |
|
I was hoping to find a way to fix the Travis build before merging, but… |
|
Released in version 2.1. |
|
Thanks a lot !! Did
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #9.