Feature firefox

[wistcc]

This PR is related to issue #46

[martynchamberlin]

Wow. Great work! Few things:

• In the future, it'd be easier to review these PRs if their repo was this one, not a fork. That way reviewers don't have to clone and npm install all the dependencies in a temporary directive. That said, are there pain points that are solved on your end by having the PR come from your own repo?
• I can't figure out how to get CORs working with FireFox. See screenshot: https://cl.ly/3q0E0B2o2647 The plugin doesn't load any content in FF until we get this fixed. I've tried mounting both the dev and the prod builds of the add on, and neither of them work locally. They both should, yes?

[martynchamberlin]

Regarding item 2 by the way, if I'm having this problem, other contributors are going to too. Let's plan on updating the README with instructions on how to get this setup. Want the barriers to entry to be as low as possible! (Documentation doesn't have to be in the PR we end up merging, per se, just sometime soon.)

[wistcc]

1- Yeah, from now on I'll do PRs on the main repository.
2- I think what you need is do this (here the source): Visit about:config and set xpinstall.signatures.required to false.

Note: @martynchamberlin please, let me know if this solves the problem if so I'll update the readme with this. :)

[martynchamberlin]

@wistcc That now makes the errors go away in the console but I'm still seeing just this: https://cl.ly/1O090j1P0Z2I

Here's what the Inspector looks like. That JavaScript file just isn't doing anything for some reason. https://cl.ly/3V0r1l2T090M

[wistcc]

@martynchamberlin just in the case we are not on the same page, please make sure you are doing this:

1- npm run devFirefox

2- On FF go to about:config and set xpinstall.signatures.required to false.

3- On FF go to about:debugging, click on Load Temporary Add-on and go to the folder called devFirefox and double click any of these files. Then you will have this:

Now you should have the extension working correctly as you can see here:

Note: you can click on debug to see the extension's console.

[martynchamberlin]

@wistcc You'll probably get a notification about wistcc#1, but in case you don't, now you do. :) Please look it over and merge into this PR if you like what you see.

To be honest, at this point knowing what I now know about Firefox's add-on specs, I have no idea how this extension has been working for you in Firefox without my PR. Super weird.

[wistcc]

@martynchamberlin As I said, from now on I'll do any contribution directly to the main repository, now is pretty obvious is the best way to go.

I suppose this should be an issue to be created, shouldn't it? Let's plan on updating the README with this policy so it's clear to contributors in the future.

[martynchamberlin]

@wistcc Sure!

[wistcc]

This PR also closes #51

@martynchamberlin please let me know if you want to add something more to the readme.

[martynchamberlin]

Thanks for adding this. You've earned it!

[martynchamberlin]

Change "this steps" to "these steps", please.

[wistcc]

@martynchamberlin comments addresed! :)

[martynchamberlin]

@wistcc Awesome. The only thing at this point is wistcc#2.

[martynchamberlin]

@wistcc Oops, my PR broke lint (and broke our build process!). This should fix it the right way. wistcc#3

[wistcc]

Oh, I should have tested it. :(

[martynchamberlin]

@wistcc Ha, no worries. I've merged this PR! Will ping you when the add-on is available for FireFox!