feat: add pgTAP and pg_prove #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villelahdenvuo
commented
May 3, 2023
|
hi @villelahdenvuo - confirming the request and we'll take a look into this |
JalexChen
suggested changes
May 31, 2023
There was a problem hiding this comment.
Hi @villelahdenvuo - thanks for the contribution. I do have a couple of changes requested. I tried pushing this up on your branch, but i am receiving the following error:
[remote rejected] HEAD -> refs/pull/81/head (deny updating a hidden ref)
Do you mind making these changes? Additionally, could you be sure to rebase on main once the changes have been made?
Thank you!
This was referenced May 31, 2023
villelahdenvuo
force-pushed
the
main
branch
2 times, most recently
from
630cb61 to
9e106bf
Compare
|
@JalexChen I implemented your changes and added a cleanup step similar to pg_cron. |
JalexChen
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #65