Skip to content

feat(gsoc): embed view of simulator #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Conversation

Arnabdaz
Copy link
Member

@Arnabdaz Arnabdaz commented Sep 6, 2023

Fixes add embed view of simulator, for circuit preview

Describe the changes you have made in this PR -

  • add embed view
  • add /simulatorvue/embed/:projectId route for embed view
  • add /simualtorvue/:projectId route for circuit preview
  • fix all logic related to embed view
  • remove usage of jquery & reduce DOM manipulation
  • test in integration of main repo & main site embed view

Screenshots of the changes (If any) -

Screencast.from.2023-09-06.19-41-51.webm

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@commit-lint
Copy link

commit-lint bot commented Sep 6, 2023

Features

  • gsoc: update api endpoints with the new api/v1 endpoints (5047684)
  • gsoc: add embed view of the simualtor (ed118ae)

Chore

  • lint: remove unused variable Update circuit.js (c44e07d)

Contributors

Arnabdaz

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit c44e07d
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/64f88dd316f49c0008438dc1
😎 Deploy Preview https://deploy-preview-187--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Arnabdaz
Copy link
Member Author

Arnabdaz commented Sep 8, 2023

cc @devartstar

@tachyons tachyons merged commit 7a816bf into CircuitVerse:main Sep 10, 2023
@tachyons
Copy link
Member

There are commentedout erb files in this file, which needs to be removed later, kept it for now to make converting to vue easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants