Skip to content

fix: panel and dropdown overlap #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

palashb01
Copy link
Contributor

  • The panels and dropdowns no longer overlaps with each other.

Fixes: #43

Describe the changes you have made in this PR -

  • Changed the z-index of multiple elements to prevent overlapping.

Screenshots of the changes (If any) -

Screenshot from 2023-01-05 07-07-47

Demo Video-

circuitverse_43.mp4

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

The elements panel and timing diagram were overlapping
with dropdowns because of z-index being 100,
changed the z-index and now the dropdowns are behaving
as expected.
Fixes: CircuitVerse#43
@commit-lint
Copy link

commit-lint bot commented Jan 5, 2023

Contributors

palashb01

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit ff7f0f6
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/63b62a279e4bba0007849dce
😎 Deploy Preview https://deploy-preview-47--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@palashb01
Copy link
Contributor Author

Hey @tachyons @devartstar , could you please review the PR and suggest if any changes are required, Thanks.

@palashb01 palashb01 changed the title fixed panel and dropdown overlap fix: panel and dropdown overlap Jan 7, 2023
Copy link
Member

@pulkit-30 pulkit-30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@devartstar devartstar enabled auto-merge (squash) January 21, 2023 08:37
@devartstar devartstar merged commit f42668f into CircuitVerse:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: panels and dropdowns overlap.
3 participants