Skip to content

Conversation

CML-TAC
Copy link
Contributor

@CML-TAC CML-TAC commented Feb 25, 2025

Added vJUNOS and vROUTER node definitions with SMBIOS Parameters and extract configuration function.

Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on HEAD and push again without the nd_validation change?

@CML-TAC
Copy link
Contributor Author

CML-TAC commented Feb 28, 2025

I have synced the fork again, please check now.

@xorrkaz
Copy link
Collaborator

xorrkaz commented Mar 1, 2025

I have synced the fork again, please check now.

Thanks. I had a typo in my check. Please re-sync and push again.

@tombry tombry self-requested a review June 27, 2025 19:06
Copy link
Collaborator

@tombry tombry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR since Joe is on vacation. There weren't any changes since Joe last approved: just a resync and push.

@tombry tombry merged commit 12aef0e into CiscoDevNet:master Jun 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants