Migrate away from pkg-resources #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroenlein
commented
Sep 8, 2023
Comment on lines
+21
to
+27
| def _deploy_default_files() -> str: | ||
| """Copy the units & constants file into a temporary directory.""" | ||
| default_dir = TemporaryDirectory() | ||
| _TEMP_DIRECTORIES.append(default_dir) | ||
|
|
||
| units_path = Path(default_dir.name) / "citrine_en.txt" | ||
| units_path.write_text(read_text("gemd.units", "citrine_en.txt")) |
There was a problem hiding this comment.
The change in package behavior required a bunch of rework here because the units file imports the constants file via a relative file link, but importlib refuses to give a path-like object (as it may be unpacking a ZIP).
bfolie
reviewed
Sep 8, 2023
| _scaling_preprocessor | ||
| ], | ||
| autoconvert_offset_to_baseunit=True) | ||
| # TODO: Pint 0.18 doesn't accept paths; must stringify |
There was a problem hiding this comment.
0.18 is an old version, yes? We'll be updating Pint soon-ish?
There was a problem hiding this comment.
Support for 0.18 gets dropped with dropping Python 3.7.
bfolie
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.7, distributing files within a package are supposed to use importlib.resources instead. This was causing a large number of import warnings.
Ostentibly no changes in functionality, though some of these interfaces deserve rethinking.