Skip to content

Add Node.js 24 CI #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Node.js 24 CI #415

wants to merge 3 commits into from

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Apr 30, 2025

Summary

This PR disables CI for Node.js 18, which is EOL, adding Node.js 24 to the matrix.
Closes #414

@slvrtrn slvrtrn changed the title Update the GHA to use Node.js 24 Add Node.js 24 CI Apr 30, 2025
@slvrtrn
Copy link
Contributor Author

slvrtrn commented Apr 30, 2025

It turned out that the release date for Node.js 24 is not 2025-04-22; it is TBD, see nodejs/Release#1081 (comment).

@slvrtrn slvrtrn closed this Apr 30, 2025
@slvrtrn slvrtrn reopened this May 7, 2025
@slvrtrn
Copy link
Contributor Author

slvrtrn commented May 7, 2025

Node.js 24 support will require fixing all imports in the project.

For example:

➜  clickhouse-js git:(ci-node-24) ✗ npm t

> [email protected] test
> .scripts/jasmine.sh jasmine.all.json

(node:163200) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Error: Cannot find package '/home/serge/work/clickhouse-js/node_modules/@clickhouse/client-common/dist/index.js' imported from /home/serge/work/clickhouse-js/packages/client-common/__tests__/unit/clickhouse_types.test.ts
Did you mean to import "file:///home/serge/work/clickhouse-js/packages/client-common/src/index.ts"?

See https://nodejs.org/api/esm.html#mandatory-file-extensions.
That will take some time to address properly.
CC @mshustov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Nodejs v24, drop v18
1 participant