-
Notifications
You must be signed in to change notification settings - Fork 15
Support the pedantic API #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the pedantic API #81
Conversation
209b49d to
57148a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It would make sense to test the benchmark.pedantic function in tests/test_pytest_plugin_walltime.py
84605a0 to
22d4d33
Compare
|
Yep I'll add a nominal test for both! |
57148a1 to
9e0797e
Compare
CodSpeed Instrumentation Performance ReportMerging #81 will not alter performanceComparing Summary
|
9e0797e to
4875846
Compare
CodSpeed Walltime Performance ReportMerging #81 will degrade performances by 7.67%Comparing Summary
Benchmarks breakdown
|
4875846 to
f38528d
Compare
f38528d to
96fe457
Compare
|
Please revert the typing changes. E.g. |
| self._called = False | ||
|
|
||
| def __call__( | ||
| self, target: Callable[..., T], *args: tuple, **kwargs: dict[str, Any] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this used to be correct, now it makes no sense at all.
what you changed it to is “each positional argument is a tuple, and each keyword argument is a dict”. So this is valid according to your typing:
benchmark(print, (), (1,2), file={})but this is invalid according to your typing:
benchmark(print, "a", file="out.txt")
Fixes #77
We'll merge both after your PR @not-matthias