Support PHPUnit 11 #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamMousa
reviewed
Feb 2, 2024
src/Stub.php
Outdated
Comment on lines
419
to
420
| if (version_compare(PHPUnitVersion::series(), '11', '>=') && !is_bool($args[1])) { | ||
| array_splice($args, 1, 0, [true, true]); |
There was a problem hiding this comment.
Do you have a reference to the updated mock call in PHPUnit that requires this change?
There was a problem hiding this comment.
Sure, it's the parameter $markAsMockObject in https://github.com/sebastianbergmann/phpunit/blob/ece3536c22fc5113906a42e7e82de00baaef36d0/src/Framework/MockObject/Generator/Generator.php#L111 which was added in sebastianbergmann/phpunit@db9ae30
Generator::testDouble() does now have an additional parameter
Naktibalda
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.