Pass sort properties to custom header renderer #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to display current sort order, we need sorting information in header renderer.
Contributor
|
+1 - I have been looking for this exact functionality for the past several hours. |
Contributor
Author
|
@rlreamy You can use https://www.npmjs.com/package/@lucjansuski/react-data-grid before it gets merged |
malonecj
approved these changes
Jan 22, 2018
malonecj
added a commit
that referenced
this pull request
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to display current sort order, we need sorting information in header renderer.
What is the current behavior? (You can also link to an open issue here)
onSort / sortDirection props are not passed to the custom headerRenderer, hence making it impossible to display sorting information
What is the new behavior?
Pass sorting props to headerRenderer
Does this PR introduce a breaking change? (check one with "x")