Optimized struct enumerators #3341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned - The one for rows is not needed from .NET Core 2.1 and above - The other has the extra ToArray API which needs the initial values to remain available, and the type to be readonly
…Sergio0694/WindowsCommunityToolkit into optimization/struct-enumerators
|
Thanks @Sergio0694, I'm still inclined to move this to 7.0 since we're trying to close down 6.1 still... @azchohfi thoughts? This still seems pretty straight-forward and should have test coverage (which pass). |
azchohfi
approved these changes
Jun 11, 2020
|
Yeah, I'm not worried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3128 and #3273
PR Type
What kind of change does this PR introduce?
@michael-hawker NOTE: this PR has no functional changes, I literally just shuffled some code around and removed some unnecessary types (as I've moved the code to the parent types). All the existing methods and operations are exactly the same as before, I didn't change anything at all there.
What is the current behavior?
The
Span<T>/T[]/T[,]enumerators use a secondary enumerator type to perform the actual enumeration. This causes an unnecessary initial copy of the captured values, and introduces a second generic type with a couple method that the JIT compiler has to compile to native code (for value types).What is the new behavior?
The
GetEnumerator()now simply returnsthis, so the second type is no longer needed. All the enumeration methods are added directly to the first type. The enumerator types are no longer marked asreadonlyto allow direct enumeration on them. This is not a problem since those were always supposed to be used once anyway and never store anywhere (as they'reref structtypes).PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates