Fix warning for GCC 14 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
approved these changes
May 17, 2024
lethosor
reviewed
May 17, 2024
Comment on lines
+436
to
+448
| #if defined(__GNUC__) && __GNUC__ > 13 | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wuninitialized" | ||
| #endif | ||
|
|
||
| Value::Value(Value&& other) noexcept { | ||
| initBasic(nullValue); | ||
| swap(other); | ||
| } | ||
|
|
||
| #if defined(__GNUC__) && __GNUC__ > 13 | ||
| #pragma GCC diagnostic pop | ||
| #endif |
There was a problem hiding this comment.
A thought: you might be able to avoid duplicating the second #if condition with
#pragma GCC diagnostic push
#if defined(__GNUC__) && __GNUC__ > 13
#pragma GCC diagnostic ignored "-Wuninitialized"
#endif
Value::Value(Value&& other) noexcept {
initBasic(nullValue);
swap(other);
}
#pragma GCC diagnostic pop(I haven't checked whether this works as expected, so don't put too much effort into it)
I might have also gone with >= 14 here, but again, untested.
There was a problem hiding this comment.
Yes. I agree the second #if isn't ideal. I'll try experimenting with that late weekend or after the weekend. Probably after the weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.