Skip to content

fix: Snowflake - Stop asserting views start with SELECT (CTEs). #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

DanCardin
Copy link
Owner

i believe that assert was more a guard against bugs in the code that processed the query, but taking into account WITH-starting queries, it just doesn't seem worth it to keep expanding the assert.

if there's some other definition structure that causes this to fail, we can address that more directly with better parsing.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (545cd8e) to head (11c747d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...declarative_extensions/dialects/snowflake/query.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   89.87%   89.86%   -0.01%     
==========================================
  Files          85       85              
  Lines        3811     3810       -1     
  Branches      778      778              
==========================================
- Hits         3425     3424       -1     
  Misses        314      314              
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanCardin DanCardin merged commit 7e4b1b3 into main Apr 8, 2025
17 of 19 checks passed
@DanCardin DanCardin deleted the dc/cte-snowflake branch April 8, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant